Conversation
antfu
approved these changes
Feb 6, 2024
Member
|
Yeah I think it makes sense to have mlly support that information later. /cc @pi0 does the interface fields looks good to you? |
Member
|
Generally yes! I would probably name it |
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 98.73% 98.74%
=======================================
Files 14 14
Lines 1822 1834 +12
Branches 371 374 +3
=======================================
+ Hits 1799 1811 +12
Misses 23 23 ☔ View full report in Codecov by Sentry. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #318
❓ Type of change
📚 Description
Added the
declarationfield inImportto distinguish between dts and enum When transfer exports to imports intoImportfunctionfindExportswill tag enum as declaration, after dedupe imports, enum can only be used as a value.Maybe add a type in
mllyESMExport is a better way? Or edit the return value afterfindExportsinstead of adding a field to theExporttype?Fix typescript enum auto import error, enum should be import as both value and type.
Resolves #318
📝 Checklist