fix(client): process pending patches even when dirty is false #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `patch()` is called during or after a render cycle, the render may complete and set `dirty = false` before the debounced render fires. This caused the debounced render to skip processing `_pending` patches. The fix checks for pending patches as a fallback when `dirty` is false, ensuring reactive updates are always rendered. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Bundle Size Analysis
|
Collaborator
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useHeadwith reactive values that change after SSR hydration would remove old tags but not add new onespatch()is called during/after a render, the render completes and setsdirty = falsebefore the debounced render fires, causing it to skip processing_pendingpatchesChanges
renderDOMHead.tsto check for pending patches as fallback whendirtyis falseTest plan
Closes #530
🤖 Generated with Claude Code