feat(packagejson): object format support for workspaces field#236
Merged
Conversation
The workspaces field was typed as string[] but should support both array and object formats according to the JSON Schema and Yarn Classic conventions. Closes `workspaces` field type missing object format support unjs#235
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 89.40% 91.22% +1.82%
==========================================
Files 5 10 +5
Lines 434 262 -172
Branches 37 61 +24
==========================================
- Hits 388 239 -149
+ Misses 46 23 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@pi0 this looks good to me, do you think we'll need a new major though? its a breaking change to the types but was already wrong 👀 |
workspaces field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspaces field was typed as
string[]but should support both array and object formats according to the JSON Schema and Yarn Classic conventions.Resolves #235
P.S. There is an example of using object syntax in an article on nohoist.
UPD2: There's also an RFC to add nohoist to npm, but this isn't implemented for now - npm/rfcs#287