Skip to content

fix: check for all lockfiles before ascending directories#179

Merged
pi0 merged 3 commits into
unjs:mainfrom
werheng:fix
May 9, 2024
Merged

fix: check for all lockfiles before ascending directories#179
pi0 merged 3 commits into
unjs:mainfrom
werheng:fix

Conversation

@werheng

@werheng werheng commented May 9, 2024

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When I use findWorkspaceDir without git, it would look for lockfile by resolveLockfile. Finding all format of the lockfile before traverse directory would be better.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

danielroe
danielroe reviewed May 9, 2024
View reviewed changes
Comment thread src/index.ts Outdated
danielroe
danielroe reviewed May 9, 2024
View reviewed changes
Comment thread src/index.ts Outdated
danielroe
danielroe approved these changes May 9, 2024
View reviewed changes

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this and think it will solve some significant downstream issues - thank you ❤️

@danielroe danielroe changed the title fix: resolve lockfile fix: check for all lockfiles before ascending directories May 9, 2024
@danielroe danielroe requested a review from pi0 May 9, 2024 10:47
@codecov

codecov Bot commented May 9, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.35%. Comparing base (afdf7cb) to head (dd843b1).
Report is 11 commits behind head on main.

Files Patch % Lines
src/index.ts 25.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   89.40%   89.35%   -0.06%     
==========================================
  Files           5        5              
  Lines         434      554     +120     
  Branches       37       38       +1     
==========================================
+ Hits          388      495     +107     
- Misses         46       59      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pi0
pi0 approved these changes May 9, 2024
View reviewed changes

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pi0 pi0 merged commit b24c863 into unjs:main May 9, 2024
@werheng werheng deleted the fix branch May 10, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@werheng @pi0 @danielroe