fix(types): support object format for PackageJson .browser#145
Conversation
PackageJson .browser
pi0
approved these changes
Oct 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 5 5
Lines 434 434
Branches 37 37
=======================================
Hits 388 388
Misses 46 46
|
Contributor
Author
|
@pi0 can u please merge this pr as I need it in my project |
danielroe
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
According to https://github.com/defunctzombie/package-browser-field-spec, browser field can be a
string, an object withstring | falsevalue. This PR adds the object support.📝 Checklist