Conversation
pi0
reviewed
Jun 26, 2024
pi0
approved these changes
Jun 26, 2024
delimiter to ; on windows
delimiter to ; on windowsdelimiter to ; in windows
pi0
approved these changes
Dec 30, 2024
delimiter to ; in windowsdelimiter to ; in windows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 99.45% 99.31% -0.14%
==========================================
Files 4 4
Lines 364 293 -71
Branches 114 120 +6
==========================================
- Hits 362 291 -71
Misses 2 2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #175
This pull request fixes the issue where the delimiter is a colon (:) on all platforms, including Windows where it should use a semicolon (;).