Skip to content

fix(parse)!: fixed root handling#168

Closed
prisis wants to merge 1 commit intounjs:mainfrom
PrisisForks:node-parse-compatibility
Closed

fix(parse)!: fixed root handling#168
prisis wants to merge 1 commit intounjs:mainfrom
PrisisForks:node-parse-compatibility

Conversation

@prisis
Copy link
Contributor

@prisis prisis commented Mar 24, 2024

πŸ”— Linked issue

#167

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #167

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@prisis prisis changed the title fix: fixed prase root handling DRAFT: fix: fixed prase root handling Mar 24, 2024
@prisis
Copy link
Contributor Author

prisis commented Apr 22, 2024

Small reminder, @pi0 :)

@prisis prisis changed the title DRAFT: fix: fixed prase root handling fix: fixed prase root handling Apr 24, 2024
@pi0 pi0 changed the title fix: fixed prase root handling fix(parse): fixed root handling Dec 30, 2024
@pi0 pi0 changed the title fix(parse): fixed root handling fix(parse)!: fixed root handling Dec 30, 2024
@pi0
Copy link
Member

pi0 commented Dec 30, 2024

Thanks for PR. Moving to #194 since push access is closed to PR.

@pi0 pi0 closed this Dec 30, 2024
@prisis prisis deleted the node-parse-compatibility branch January 1, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should pathe parse have the same return logic like node:path parse

2 participants