feat: add genDynamicTypeImport
#125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 336 354 +18
Branches 82 87 +5
=========================================
+ Hits 336 354 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KazariEX
commented
Oct 6, 2025
genDynamicTypeImport
danielroe
approved these changes
Nov 6, 2025
Member
danielroe
left a comment
There was a problem hiding this comment.
this looks great - thank you ❤️
danielroe
reviewed
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating types for auto imports, we usually access properties using
['...']directly. However, when this appears aftertypeof import('...'), the identifier at that position is not a valid reference. I would like to have a util that helps us generatetypeof import('...').defaultinstead oftypeof import('...')['default']whenever possible.