Skip to content

chore: configure rule @typescript-eslint/no-unused-vars#229

Closed
JLarky wants to merge 1 commit into
unjs:v1from
JLarky:feat/improve-no-unused-vars
Closed

chore: configure rule @typescript-eslint/no-unused-vars#229
JLarky wants to merge 1 commit into
unjs:v1from
JLarky:feat/improve-no-unused-vars

Conversation

@JLarky

@JLarky JLarky commented Apr 30, 2024

Copy link
Copy Markdown
  • this allows me to remove lint ignore
  • vars starting with _ are allowed now (as they should be)

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

- this allows me to remove lint ignore
- vars starting with _ are allowed now (as they should be)
@JLarky

JLarky commented Apr 30, 2024

Copy link
Copy Markdown
Author
image

@pi0

pi0 commented May 1, 2024

Copy link
Copy Markdown
Member

Thanks this is a good idea with ignoring _*! Do you mind to please port it to unjs/eslint-config rules? 🙏🏼

@JLarky

JLarky commented May 1, 2024

Copy link
Copy Markdown
Author

so I need to split this PR into lint rule changes in that repo and also PR to clean up this stuff, right?

image

@pi0

pi0 commented May 2, 2024

Copy link
Copy Markdown
Member

@JLarky Yes. Actually we have some kind of automation with renovate bot that automatically updates deps (eslint preset) + autofix ci it should automatically removed extra rule. Let's see what happens 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants