main,json-writer: allow the writer to disable "fixed" fields#2080
Merged
masatake merged 1 commit intouniversal-ctags:masterfrom Apr 16, 2019
Merged
Conversation
b8f212d to
e880faf
Compare
Close universal-ctags#2065. The tags format must include name, input, and pattern fields. When running ctags, disabling them are not allowed. To implement this rule, "fixed" fields were introduced to field.c. However, this rule is applicable only to the ctags writer. The other writer like json-writer doesn't need to follow the rule. The fixed field is implemented in field.c. Now, it moves to writer-ctags.c. As the result, json-writer can print the result with disabling "name", "input", and/or "pattern". Signed-off-by: Masatake YAMATO <yamato@redhat.com>
e880faf to
8182f84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2065.
The tags format must include name, input, and pattern fields.
When running ctags, disabling them are not allowed. To implement
this rule, "fixed" fields were introduced to field.c.
However, this rule is applicable only to the ctags writer. The
other writer like json-writer doesn't need to follow the rule.
The fixed field is implemented in field.c. Now, it moves to writer-ctags.c.
As the result, json-writer can print the result with disabling
"name", "input", and/or "pattern".
Signed-off-by: Masatake YAMATO yamato@redhat.com