Fix MCP: Successful responses contain duplicate outputs #6082
+13
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notify was appending to outputVar twice - once always, once in the else branch. Simplified to a single append with for errors.
2 tasks
Contributor
|
@kn0ll Whoops, thanks. |
Contributor
Author
|
@aryairani yes, perfect, thank you! |
aryairani
approved these changes
Jan 2, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is apparent from the
mcp.mdtranscript, the MCP is returning duplicate responses when they are successful.This can be transparent to the user for but:
The bug is that the output was being appended once, then again in a failure handling branch.
I assume the diff is small enough that the
mcp.mdtranscript is sufficient for testing.