let text.find detect numbers in patterns
#6079
Merged
+35
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#6073 reported that
text.finddoesn't findNatliterals in pattern matches.See transcript diff for before and after.
Closes #6073
What does this change accomplish and why?
Include "before and after" examples if appropriate. (You can copy/paste screenshots directly into this editor.)
List any Github issues that this PR closes, in closing-issues-using-keywords format.
Implementation approach and notes
Changes
txtPatternto recognize more thatTextcases.Interesting/controversial decisions
I wasn't sure if
showwas the right move here or if we needed something more sophisticated, but it's a step in the right direction in any case.Test coverage
Have you included tests (which could be a transcript) for this change, or is it somehow covered by existing tests?
Would you recommend improving the test coverage (either as part of this PR or as a separate issue) or do you think it’s adequate?
adequate
n/a
Loose ends
It doesn't work to use a negative number to search for a negative number, not sure why yet, but that limitation already existed.
n/a
Final checklist
.cabalfiles, make sure thepackage.yamlfiles are up-to-date instead.