Support single-quotes in ucm arg parsing #6072
Merged
+19
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Cool. In the new year maybe we can brainstorm something to make the transcripts CI checks' useful to annoying ratio better. |
aryairani
approved these changes
Dec 19, 2025
Contributor
ceedubs
approved these changes
Dec 19, 2025
Contributor
ceedubs
left a comment
There was a problem hiding this comment.
Wow what a quick turnaround. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
@ceedubs noticed we currently parse single-quotes as part of the string, which isn't great 😓
https://discord.com/channels/862108724948500490/1200119393061969951/1451599108010676235
This changes the arg parser to understand single or double quotes.
Implementation approach and notes
Small tweak to the parser
Test coverage