Re-enable paged output after a file event. #6045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
An interesting glitch from the Discord;
https://discord.com/channels/862108724948500490/1444704371295129741
User reported that after updating the scratch file the pager no longer worked;
Implementation approach and notes
Turns out an IORef was being disabled on every File Event, but was never being re-enabled.
I changed it so that whether an output is paged depends on the output message itself.
Interesting/controversial decisions
I considered a couple approaches (see commit history);
notifyof the Env before running each stepI went with the latter approach since it seems the most semantically correct to me, and is also the most flexible.
Test coverage
Tested manually; seems tough to add an automated test for this one