Prevent hash failure errors in runtime #6038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceedubs
approved these changes
Dec 5, 2025
Contributor
ceedubs
left a comment
There was a problem hiding this comment.
I won't pretend to understand anything about this, but I can confirm that with this branch all of the Unison Cloud tests now pass.
Contributor
|
Thanks @ChrisPenner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fast-follow to #6035;
While that seems to have addressed errors for internal let-bindings, it didn't address the floated runtime bindings.
Now we just ignore any incomplete-element-ordering warnings returned from hashing top-level components in the runtime.
Implementation approach and notes
Test coverage
@unison/cloudtests and the@unison/jsontests without failures.