Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Internal ticket
Adds the fully-qualified-name to the rendered syntax text JSON.
Implementation approach and notes
Just adds a new
fqnkey to the JSON forTypeReference, DataConstructorReference, AbilityConstructorReference, TermReferencesyntax text elements. It's a little awkward it's not incontentsor w/e, but can't do that and still be back-compatible. It's fine as is IMOThis value will be null if a given hash doesn't have a name in scope. Possibly also when using old cached syntax texts; but we can choose to clear the old caches if desired.
Test coverage