pretty-print symboly binders with surrounding parens #6030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What does the fix for the type vars version look like? Would you open a ticket |
aryairani
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5317
Test coverage
I've added a transcript that demonstrates the fix
Loose ends
In investigating this issue, I discovered that we are also willing to generate symboly type variables (when a user doesn't supply a type sig) that we can't then parse back.
Example type signature:
That seems related to this issue, though probably not as likely to actually happen.
FWIW, I'm not sure we should have ever even allowed symboly binders, but that ship has probably sailed