Skip to content

Conversation

@aryairani
Copy link
Contributor

@aryairani aryairani commented Nov 13, 2025

Overview

  • What does this change accomplish and why?

    Why: Make transcripts idempotent #5406 also introduced that docs and GitHub templates would be run through the transcript runner. I think it was to give more ambient testing of the transcript parser; but it made it so that we couldn't just edit the docs and templates without rerunning the transcripts, to satisfy the other rule that transcript outputs should be up to date in PRs.

    What: Don't do that anymore. It was partially reverted in Don’t treat docs as transcripts #5903 (docs) and recently worked around in run transcripts #5996. This PR removes the Github templates from the transcript list too.

    • i.e. How does it change the user experience?
      No impact on Unison users

    • i.e. What was the old behavior/API and what is the new behavior/API?
      n/a

  • Include "before and after" examples if appropriate. (You can copy/paste screenshots directly into this editor.)

  • List any Github issues that this PR closes, in closing-issues-using-keywords format.

Implementation approach and notes

Interesting/controversial decisions

I left in the call to the empty list, in case we want to manually add some documents back later.

Test coverage

  • Have you included tests (which could be a transcript) for this change, or is it somehow covered by existing tests?

    it's more of a CI issue

  • Would you recommend improving the test coverage (either as part of this PR or as a separate issue) or do you think it’s adequate?

    n/a

  • If you only tested by hand, because that's all that's practical to do for this change, mention that. Include screenshots.

    tested by hand with ./scripts/check.sh and it didn't recreate any of the corresponding output files in my working dir. 👍

Loose ends

n/a

Final checklist

  • Choose your PR title well: Your pull request title is what's used to create release notes, so please make it descriptive of the change itself, which may be different from the initial motivation to make the change.
  • Update your PR description if the specifics of the PR have changed over time.
  • Include transcripts or screenshots that demonstrate the changed behavior.

@aryairani aryairani merged commit 177d063 into trunk Nov 14, 2025
31 checks passed
@aryairani aryairani deleted the topic/dont-transcript-ghtemplates branch November 14, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants