fix upgrade fzf behavior #5981
Merged
fix upgrade fzf behavior #5981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
approved these changes
Nov 3, 2025
ceedubs
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the
upgradefzf behavior. On trunk, a zero-argumentupgradewill keep asking for completions forever, but neither Ctrl+C nor Ctrl+D to stop providing libraries does the right thing.In this PR, a zero-arg
upgradelaunches FZF twice. If you want to do a multi-library upgrade, you have to type out all of the library names manually, without FZF.Implementation notes
I reverted the new
ZeroPlus"trailing parameter" type that I added when generalizingupgradeto take more than 2 arguments. It turns out we already had the trailing parameter type we wanted, calledOptional, I just misunderstood how it worked.Test coverage
I tested this change manually