Strictify LSP Vars #5978
Merged
Strictify LSP Vars #5978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we wait for @ceedubs to give this branch a try, or should I just merge it? |
Contributor
|
I gave it a brief try and it at least didn't seem any worse. But I wasn't able to try it long because I needed to try out another branch with some changes from Dan. I say go for it. |
aryairani
approved these changes
Nov 4, 2025
Contributor
|
Merging this as a "may not help but doesn't make things worse, and doesn't make the code uglier" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
@ceedubs has been noticing some memory leaks which seem to be related to LSP;
I only did a quick look, and didn't find anything too egregious, but here are a few quick strictifications.
If leaks persist then I'll look in deeper and do more experiments