Fix completion edge-cases #5975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is ready to go but I can't convince Github Actions to build it, it seems to be failing to acquire an ubuntu-arm worker to run that part of the matrix and just decides to cancel the whole job and give up if it doesn't acquire one within 15 minutes. |
Member
Author
|
Ah, looks like a github outage, I'll try again tomorrow or something. 
|
aryairani
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Noticed some edge-cases with the newly merged #5968 ;
Implementation notes
Fix up behaviour around adding spaces after completed args, and completing the next arg when you've added a space after the previous one.
Test coverage
Tested behaviour manually to get parity on these against latest release