Fix a runtime problem from overapplying ability requests #5970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When continuations with captured pending arguments were called, it was possible to have situations that discarded those arguments, similar to an erroneous `yield`. There is explicit logic in the latter to apply the yielded result to the pending arguments that was absent in the continuation case. This adds comparable logic to the continuation call.
pchiusano
approved these changes
Oct 28, 2025
Contributor
Author
|
Base tests pass. |
Contributor
|
I'll run the cloud integration tests with this. |
ceedubs
approved these changes
Oct 28, 2025
Contributor
ceedubs
left a comment
There was a problem hiding this comment.
Oops forgot to send an update right away, but cloud integration tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the runtime implementation of calling continuations.
There was missing logic related to the continuation having captured pending arguments. In the
Yieldcase there is logic that looks for these, and applies a function result to the pending arguments. This was missing from the continuation call case, which should behave similarly (because a continuation call is implemented as 'push captured continuation back and yield arguments').It's apparently tricky to actually get into situations that actually trigger the previously bad logic. I think usually it is covered by the logic for
Yield, because the continuation happens to have also captured a frame that justYields its argument. However, we have an example of a more complicated situation that triggers the old bug, included in a test case here.Fixes #5947.