Try to fix typecheck schema usage in Codex #5957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
approved these changes
Oct 22, 2025
aryairani
approved these changes
Oct 23, 2025
Contributor
|
I installed codex as a command-line tool and that worked better than as a vscode plugin. Here's codex 0.47.0 with ucm 0.5.49': and with this branch: also worked with a file; ignore the red: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Seems like there are some (not fully explored) problems with oneOf/allOf in some Agent's validation of JSON Schemas.
This seemed to be confusing Codex, so I switched the typecheck tool to just take one of two optional params instead; which will hopefully be more portable across agents.
Implementation notes
oneOftagged union schema to just two optional keys with a requirement that at least one is provided.Test coverage
Can't test it on codex, but the transcript still applies.