Speed up serialized value loading #5928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two changes: 1. The traversal was using `dereference`, which could pessimize the case where references were factored out considerably (lots of reference comparisons). 2. Made the traversal for collecting references able to optimize better via some transforms.
These are dedicated, more efficient array traversals, and more direct conversion between runtime and reflection representations.
Contributor
|
Some conflicts with another Runtime PR? |
aryairani
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the process of reification of serialized values back into runtime values a bit. It can be around twice as fast as it previously was, depending on what you're reifying. The bulk of the work is just making various traversals involved better, and go through fewer intermediate representations.