fix new project name rules #5906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
reviewed
Sep 29, 2025
| ( "Please" | ||
| <> IP.makeExample IP.projectRenameInputPattern [] | ||
| <> "them using only ASCII letters, numbers, and hyphens, of length 2-40 characters." | ||
| <> "them using only ASCII letters, numbers, hyphens, and underscores. (You also can't use the name 'code' or 'p')." |
Contributor
There was a problem hiding this comment.
Could you update this to only add "(You also can't use the names 'code' or p.)" if they do have projects with one of those names. Note "name" -> "names" and ")." -> ".)"
aryairani
reviewed
Sep 29, 2025
unison-core/src/Unison/Project.hs
Outdated
| chunkLength :: (Maybe Char, Text) -> Int | ||
| chunkLength (maybeHyphen, chunk) = | ||
| (if isJust maybeHyphen then 1 else 0) + Text.length chunk | ||
| name <- Megaparsec.takeWhile1P Nothing \c -> Char.isAscii c || Char.isDigit c || c == '-' || c == '_' |
Contributor
There was a problem hiding this comment.
I think Char.isAscii will accept "@#$%^" etc. and probably should be Char.isAsciiUpper c || Char.isAsciiLower c?
If so, it's begging for some unit tests!
Member
Author
There was a problem hiding this comment.
Oops, good catch! Nonetheless I don't think this needs unit tests, but it does need to be right 😛
aryairani
approved these changes
Sep 29, 2025
Contributor
aryairani
left a comment
There was a problem hiding this comment.
Thanks for the quick fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
New project name rules: 1+ characters in the set {ascii letter, digit,
-,_}. Can't beporcode.