Skip to content

Conversation

@sellout
Copy link
Contributor

@sellout sellout commented Sep 10, 2025

In #5661, exceptions were made much prettier, but also accidentally double-prettified in cases where they were written to then read back off the stack. This reverts that double-prettification.

Fixes #5864.

@sellout sellout marked this pull request as draft September 10, 2025 13:07
In unisonweb#5661, exceptions were made much prettier, but also accidentally
double-prettified in cases where they were written to then read back off
the stack. This reverts that double-prettification.

Fixes unisonweb#5864.
@sellout sellout force-pushed the improve-internal-errors branch from ef36bb6 to f7c4c1a Compare September 10, 2025 21:22
@sellout
Copy link
Contributor Author

sellout commented Sep 10, 2025

NB: This switches back to @unison/runtime-tests/releases/0.0.3, which isn’t ideal, but I think the lesser of two evils. I’m not sure what to do about release/0.0.4, though – is there a way to deprecate a release? I.e., it’d still be there, but latest would be 0.0.3.

@sellout sellout marked this pull request as ready for review September 10, 2025 21:29
@sellout sellout requested a review from a team as a code owner September 10, 2025 21:29
@sellout
Copy link
Contributor Author

sellout commented Sep 10, 2025

I re-ran the failing transcript job, but it’s failing on the issue that is fixed by #5869 (the PR that depends on this one).

@aryairani
Copy link
Contributor

NB: This switches back to @unison/runtime-tests/releases/0.0.3, which isn’t ideal, but I think the lesser of two evils. I’m not sure what to do about release/0.0.4, though – is there a way to deprecate a release? I.e., it’d still be there, but latest would be 0.0.3.

That's okay — I assume we'd need to release a 0.0.5?

What was the difference between 0.0.3 and 0.0.4 that should be deprecated?

@aryairani aryairani merged commit 4f7fe20 into unisonweb:trunk Sep 10, 2025
29 of 31 checks passed
@sellout
Copy link
Contributor Author

sellout commented Sep 10, 2025

That's okay — I assume we'd need to release a 0.0.5?

Yeah – can that just be cut from 0.0.3, or does it need a new contribution?

What was the difference between 0.0.3 and 0.0.4 that should be deprecated?

The formatting of some error messages that were written to, then read from the Unison stack. It’s an unfortunate reversion, but I don’t know how to fix this issue (as well as #5869) while keeping those. I think reverting is the lesser of two evils.

@sellout sellout deleted the improve-internal-errors branch September 10, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug Failure message includes extra content

2 participants