Skip to content

Conversation

@sellout
Copy link
Contributor

@sellout sellout commented Aug 27, 2025

This is a duplicate of #5827, for testing the new CI workflow, which won’t (yet) work from a fork.

sellout added 13 commits August 7, 2025 21:05
This seems to have been broken for almost a year.

- Add missing packages to cabal.project
- Allow newer `numerals` deps, as in Stack (this was mentioned in
  #5142 (comment)
  but never made it in)
- Disable `terminfo` flag for haskeline, as in Stack (eliminates a
  complaint about not finding libtinfo.so)
- Add a constraint on text-builder, since 1.0.0 has been released, but
  is incompatible

This also adds some comments and sorts the constraints list.
This reduces the chance of not setting flags on individual packages (for
example., I added unison-runtime in the previous commit, but didn’t set
these flags, and it resulted in a bunch of warnings)

It also adds flags that were missing relative to stack.yaml, and it’s
lenient with deprecations in the Cabal build, as described in the
comment there.
This should make our builds more consistent between Stack & Cabal.
Makes it easier to keep cabal.project up to date if you can eyeball things.

The one substantive change here is that cabal.project adds `constraints`
for non-Stackage packages that are pinned in stack.yaml.
It previously applied to a caching step, but now applies to the `on.pull_request.paths`.
@sellout sellout force-pushed the sellout/simplify-cabal branch from 271d108 to f140aed Compare August 27, 2025 19:23
@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2025

⚠️ The sha of the head commit of this PR conflicts with #5827. Mergify cannot evaluate rules on this PR. ⚠️

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2025

⚠️ The sha of the head commit of this PR conflicts with #5827. Mergify cannot evaluate rules on this PR. ⚠️

We now have a freeze file committed to the repo, which matches the Stack
resolver, so just use that one.
Cabal failing to build the package won’t cause any CI jobs to fail, but
it will add a comment to the PR. The comment is removed when the Cabal
build is fixed.
@sellout sellout force-pushed the sellout/simplify-cabal branch from 48c1fef to 8ffa4b8 Compare August 27, 2025 20:08
@sellout sellout closed this Aug 28, 2025
@sellout sellout deleted the sellout/simplify-cabal branch August 28, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants