-
Notifications
You must be signed in to change notification settings - Fork 291
Sanity check Cabal build (testing) #5850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been broken for almost a year. - Add missing packages to cabal.project - Allow newer `numerals` deps, as in Stack (this was mentioned in #5142 (comment) but never made it in) - Disable `terminfo` flag for haskeline, as in Stack (eliminates a complaint about not finding libtinfo.so) - Add a constraint on text-builder, since 1.0.0 has been released, but is incompatible This also adds some comments and sorts the constraints list.
This reduces the chance of not setting flags on individual packages (for example., I added unison-runtime in the previous commit, but didn’t set these flags, and it resulted in a bunch of warnings) It also adds flags that were missing relative to stack.yaml, and it’s lenient with deprecations in the Cabal build, as described in the comment there.
This should make our builds more consistent between Stack & Cabal.
Makes it easier to keep cabal.project up to date if you can eyeball things. The one substantive change here is that cabal.project adds `constraints` for non-Stackage packages that are pinned in stack.yaml.
It previously applied to a caching step, but now applies to the `on.pull_request.paths`.
271d108 to
f140aed
Compare
Contributor
|
|
1 similar comment
Contributor
|
|
We now have a freeze file committed to the repo, which matches the Stack resolver, so just use that one.
Cabal failing to build the package won’t cause any CI jobs to fail, but it will add a comment to the PR. The comment is removed when the Cabal build is fixed.
48c1fef to
8ffa4b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #5827, for testing the new CI workflow, which won’t (yet) work from a fork.