Clean up pinned buffer socket/handle reads #5841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ties up loose ends in the implementation of several I/O buffer operations by adding proper length parameters and bounds checking, making them safer and more consistent with established patterns.
Namely:
IO.fillBuf.implandIO.getBufSome.implto accept a length parameter:Handle → PinnedByteArray g → Nat → {IO} Nat. Added bounds checking. This is to make these operations more flexible and useful in practice. I realized that making the primitive operations only ever completely fill the buffer makes it hard/dangerous to write abstractions on top of these.