Handle case where a handler's type is an existential variable #5834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchiusano
approved these changes
Aug 12, 2025
Member
pchiusano
left a comment
There was a problem hiding this comment.
Nice. I am really enjoying all these little fixes!
Contributor
|
Whoops, I misread the CI results; hopefully it passes 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would just error out. Instead, we now do a subtyping check against a fabricated handler request type. This allows type checking to progress, so you can reach other error error states. So for instance, if the handler is a blank, as in #5304, it will now properly report that it doesn't know what the handler is referring to, instead of being a type error.
Fixes #5304