Remove 1 of 2 remaining ORMOLU_DISABLE pragmas
#5828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other one is more entangled, but this one just required breaking out some derived instances. Not sure if this is a win, but I had the sitting in a stash, so figured I’d let someone else decide. It also turns the comments on the affected `data` decl into Haddock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Not sure if this is a win, but I had the sitting in a stash, so figured I’d let someone else decide.
It also turns the comments on the affected
datadecl into Haddock.Interesting/controversial decisions
It separates out a
derivingclause into multiple standalone deriving decls, which is more verbose.Test coverage
It’s a straight-up refactor. Everything continues to pass.
Loose ends
The remaining
ORMOLU_DISABLEis more entangled, so I don’t see it going anywhere.