Skip to content

Conversation

@ChrisPenner
Copy link
Member

@ChrisPenner ChrisPenner commented Aug 4, 2025

Overview

Allows setting the env var UNISON_MIGRATION=auto to skip migration prompts.

Requested by @ceedubs for CI jobs, where prompting doesn't make sense.

Implementation notes

Adds an env var, checks it at migration time.

Test coverage

I tested it on an old codebase I had sitting around and it worked fine :)

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you!

@aryairani
Copy link
Contributor

Heh, I didn't realize we already had

let shouldPrompt = True

so that makes it easy. Good thinking!

@aryairani
Copy link
Contributor

aryairani commented Aug 4, 2025

Side note: Maybe we should make it, especially for those docs/ transcripts, that it only fails CI if the transcript itself fails; and that otherwise it just tries to automatically check in the result.

I get hit by that one in particular too often.

@aryairani aryairani merged commit b2f6988 into trunk Aug 4, 2025
31 checks passed
@aryairani aryairani deleted the cp/no-migration-prompt branch August 4, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants