Attempt to improve function under-application and over-application errors #5665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Uses heuristics to detect function over and under application and provide better information on how to fix it.
Under-applied:
Before:

After:

And a case where a function is over-applied.
Before

After

Implementation notes
Interesting/controversial decisions
There may be cases where this is incorrect, but I think the benefit is worth that risk, we can dogfood it and tweak or roll-back as needed.
Test coverage
See new transcripts