Skip to content

Conversation

@ChrisPenner
Copy link
Member

Overview

Realized we weren't actually using the codebase config for anything anymore.

AFAIK most maintainers aren't much a fan of configurator and we've talked in the past about replacing it. Getting rid of it now seems like an auspicious plan so we're actually motivated to replace it with something better if/when we need to.

For codebase-level config it seems like we've been leaning towards just putting things in SQLite, but could also just use TOML, YAML or JSON or w/e

As a bonus, getting rid of this removes a file-watch thread and means we don't need to parse the config on every startup.

Implementation notes

Wipe out configurator entirely.

@ChrisPenner ChrisPenner marked this pull request as ready for review August 26, 2024 16:44
@ChrisPenner ChrisPenner requested a review from aryairani August 26, 2024 16:48
@aryairani aryairani merged commit 6299fc3 into trunk Aug 26, 2024
@aryairani aryairani deleted the cp/kill-config branch August 26, 2024 17:44
@ChrisPenner ChrisPenner mentioned this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants