Prod #532
Merged
Prod #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have made a comment on an associated issue in the Array API test suite. Might be a small bug on their side. |
Contributor
Author
|
Thank you, Dan. I hope they fix it soon. |
Contributor
Author
|
@djl11 Sorry Dan, The error you mentioned there can be fixed from our side by if statement. I already made if statement here. |
|
I have suppressed the unit test for now, and added a comment that this test is failing due to a bug with the Array API test suite. Thanks for the contribution! |
Contributor
Author
|
Thank you Dan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added prod function
Have 3 errors in PyTorch
2 because of dtype PyTorch does not support uint16 , uint32 and uint64
1 error because of not applicable test case
this error is right because of the tesor is 1 dim (0) there is no axis 1
Should I handle these errors or the problem in test cases?