Skip to content

Added abs function for paddlepaddle frontend #15987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ishticode merged 7 commits into from
Jun 2, 2023
Merged

Added abs function for paddlepaddle frontend #15987

Ishticode merged 7 commits into from
Jun 2, 2023

Conversation

@yashsandansing
Copy link
Contributor

@yashsandansing yashsandansing commented May 28, 2023

close #15976

@yashsandansing
Copy link
Contributor Author

yashsandansing commented May 29, 2023

Hi @Ishticode could you please review this PR?
There seems to be just 1 fail which ig is common to all paddlepaddle tasks

@Ishticode
Copy link
Contributor

Ishticode commented May 30, 2023

@yashsandansing Thank you very much for the PR. I think this looks good. Should be able to merge when I run the tests. But could u resolve conflicts and tag me. Let me know if you need any help or have any questions. Thank you very much. 🙂

@yashsandansing
Copy link
Contributor Author

yashsandansing commented Jun 1, 2023

Hey @Ishticode I have resolved the conflicts and the PR is ready to be reviewed again

Ishticode
Ishticode approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge. We should be careful not to remove decorators from other functions. Ive added back the decorators for the function multiply.
Thank you very much for the contribution @yashsandansing
🙂

@Ishticode Ishticode merged commit b33367c into ivy-llc:master Jun 2, 2023
@yashsandansing
Copy link
Contributor Author

yashsandansing commented Jun 3, 2023

Thanks for the merge @Ishticode
I did try to make sure that I did not remove anything while committing but I guess I must have overlooked it.
Thanks for pointing it out. I'll make sure it won't happen again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ishticode Ishticode Ishticode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ishticode Ishticode

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

abs

2 participants

@yashsandansing @Ishticode