Add explicit dependency on @types/unist#146
Conversation
We import directly from 'unist', so it should be make an explicit dependency. This ensures we are using the latest version of unist.
|
cc @wooorm @remcohaszing @ChristianMurphy Should I bump unified's (patch?) version number too, so the change in typing doesn't affect packages depending on the old system? |
|
Btw @ChristianMurphy @wooorm I'm working through the main unified packages to update I've done a few repos (for the most part, the code doesn't need changing, just the dependencies), but I want to check with you both that I'm doing the correct thing before I go ahead with the others. |
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
This comment has been minimized.
This comment has been minimized.
Thanks @GuiltyDolphin! |
|
Alright! I'll keep checking through then, but without updating version numbers and just make sure that typings are okay for the latest version of |
@types/unist
Initial checklist
Description of changes
This PR adds the latest version of
@types/unistan explicit dependency (as we import from it directly).Edit: I notice in the description that dependency on
@types/unistis suggested for projects using typescript - is there a particular downside to depending on it directly here?