Update typings to support ESM#141
Merged
ChristianMurphy merged 5 commits intounifiedjs:mainfrom Jun 30, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
📓 the removal of namespace makes this diff look larger than it is. |
Member
Author
|
/cc @remcohaszing |
wooorm
approved these changes
Jun 26, 2021
Member
wooorm
left a comment
There was a problem hiding this comment.
Should the tsconfig also be updated to support ES2020? https://github.com/unifiedjs/unified/blob/main/types/tsconfig.json
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
wooorm
approved these changes
Jun 30, 2021
This comment has been minimized.
This comment has been minimized.
Member
Author
|
This will be a part of unified version 10 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Update typings to support ESM style imports (part of dc46bc5)
For now keeping the typings as a
.d.tsfile, JSDoc could be nice down the road, but overload support and split interfaces (FrozenProcessorvsProcessor) are still challenging in JSDoc and potentially more difficult to maintain than the.d.tsfile.