Closed
Conversation
Merged
Contributor
|
@Manishearth The if let Some(incb_linker_count) = self.incb_linker_count {
self.ris_count = if incb_linker_count > 0 && crate::tables::is_incb_linker(ch) {
Some(incb_linker_count - 1)
} else if crate::tables::derived_property::InCB_Extend(ch) {
Some(incb_linker_count)
} else {
None
};
}Instead of After that modification, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state machines for the reverse iterators are tricky. I managed to fix the specific issue in
test_wordswhere an emoji zwj sequence is not occurring but we lose our actual state by preemptively checking.Unfortunately this causes reliable failures in the quickcheck test.
Haven't looked at the grapheme one. I don't plan on working on this soon, so if someone wants to have a look they're welcome to.