Skip to content

1.13.1 doesn't compile on Rust 1.85 but no MSRV listed #162

@pdh11

Description

@pdh11

The "is_multiple_of" method on unsigned types was only stabilised in Rust 1.87. But unicode-segmentation 1.13.1 doesn't list an MSRV, so my crate's 1.85 CI build cheerfully downloads it (as a nested dependency of ratatui) and then fails.

Using "is_multiple_of" in grapheme.rs is certainly clearer than open-coding it. But if you're going to keep it, could you add a rust-version tag for 1.87 to your Cargo.toml? that way modern resolvers won't select unicode-segmentation 1.13.1 when targeting Rusts as old as 1.85.

Version 1.12 of unicode-segmentation doesn't use "is_multiple_of", and so works fine on Rust 1.85.

(Conversely, if you'd declared an older MSRV, your CI wouldn't have moaned at you about not using "is_multiple_of".)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions