Skip to content

ICU-22718 Export disallowed/ignored UTS 46 data for ICU4X#2945

Merged
markusicu merged 1 commit intounicode-org:mainfrom
hsivonen:icu4x-uts46bis-main
May 15, 2024
Merged

ICU-22718 Export disallowed/ignored UTS 46 data for ICU4X#2945
markusicu merged 1 commit intounicode-org:mainfrom
hsivonen:icu4x-uts46bis-main

Conversation

@hsivonen
Copy link
Copy Markdown
Member

@hsivonen hsivonen commented Apr 3, 2024 •
edited
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22718
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@hsivonen hsivonen mentioned this pull request Apr 4, 2024
Merged
@hsivonen
Copy link
Copy Markdown
Member Author

hsivonen commented Apr 4, 2024

The ICU4X PR is unicode-org/icu4x#4712

@markusicu markusicu self-assigned this Apr 11, 2024
@markusicu markusicu requested a review from echeran April 11, 2024 16:18
@hsivonen hsivonen marked this pull request as ready for review April 24, 2024 14:58
@hsivonen hsivonen force-pushed the icu4x-uts46bis-main branch from cd05a16 to 19c4550 Compare May 10, 2024 11:58
@jira-pull-request-webhook
Copy link
Copy Markdown

jira-pull-request-webhook bot commented May 10, 2024

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@hsivonen hsivonen force-pushed the icu4x-uts46bis-main branch from 19c4550 to 1144c71 Compare May 10, 2024 12:01
@jira-pull-request-webhook
Copy link
Copy Markdown

jira-pull-request-webhook bot commented May 10, 2024

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu reviewed May 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failure seems to pop up for any C++ change now :-(
I will send an email to the team.

@hsivonen hsivonen force-pushed the icu4x-uts46bis-main branch from 1144c71 to c68efe0 Compare May 14, 2024 10:49
@jira-pull-request-webhook
Copy link
Copy Markdown

jira-pull-request-webhook bot commented May 14, 2024

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu
Copy link
Copy Markdown
Member

markusicu commented May 14, 2024

Please rebase and resolve the merge conflict.

@hsivonen hsivonen force-pushed the icu4x-uts46bis-main branch from c68efe0 to 2c00ab4 Compare May 15, 2024 07:00
@jira-pull-request-webhook
Copy link
Copy Markdown

jira-pull-request-webhook bot commented May 15, 2024

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@hsivonen hsivonen force-pushed the icu4x-uts46bis-main branch from 2c00ab4 to a2dbaa3 Compare May 15, 2024 07:02
@jira-pull-request-webhook
Copy link
Copy Markdown

jira-pull-request-webhook bot commented May 15, 2024

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@hsivonen
Copy link
Copy Markdown
Member Author

hsivonen commented May 15, 2024

Rebased. Adapted to the line-number-reporting error handling and fixed stylistic consistency of comparing for zero.

@hsivonen
Copy link
Copy Markdown
Member Author

hsivonen commented May 15, 2024

Backport in #3009

@markusicu markusicu merged commit 3988908 into unicode-org:main May 15, 2024
@hsivonen hsivonen deleted the icu4x-uts46bis-main branch May 20, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markusicu markusicu markusicu approved these changes

@echeran echeran Awaiting requested review from echeran

Assignees

@markusicu markusicu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hsivonen @markusicu