Replace static "require" to dynamic "read"#137
Merged
Conversation
This allow to read dynamically changes package.json file. For example, in runtime when we run script that update package.json version and create release on github. * In case, when we use `require`, it will holds content of package.json and not change it while script not started again. So, we can't read actual version from it, because it changed in runtime * In case, when we use `read`, we always read fresh state of package.json with latest actual changes
bcomnes
approved these changes
Aug 3, 2021
bcomnes
left a comment
Collaborator
There was a problem hiding this comment.
Fine with me, thoughts @ungoldman
Owner
|
seems ok to me 👍 |
Contributor
Author
|
Have we a chance to merge it? |
Collaborator
|
Sorry, fell through the cracks. Will get it out today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allow to read dynamically changes package.json file.
For example, in runtime when we run script that update package.json version and create release on github.
In case, when we use
require, it will holds content of package.json and not change it while script not started again. So, we can't read actual version from it, because it changed in runtimeIn case, when we use
read, we always read fresh state of package.json with latest actual changes