🧪 Add edge case tests for is_approved#5
Conversation
Adds a test function `is_approved_should_validate_tool_name_and_args` to verify edge cases for the `is_approved` function. It covers: - Correct match - Mismatched tool name - Mismatched tool args - Expired token - Missing token Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Adds a test function `is_approved_should_validate_tool_name_and_args` to verify edge cases for the `is_approved` function. It covers: - Correct match - Mismatched tool name - Mismatched tool args - Expired token - Missing token Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
🎯 What: The testing gap in
is_approvedinsidemcp.rsis addressed.📊 Coverage: Scenarios including missing token, expired token, mismatched tool names, mismatched arguments, and a correct match are now tested.
✨ Result: Enhanced test coverage that reliably verifies the
is_approvedbehavior and catches potential regressions when token approvals are checked.PR created automatically by Jules for task 15995856455789298653 started by @undivisible