🧪 Add test for connection read error handling#29
Conversation
Adds a test to `handle_connection` in `crates/poke-around/src/mcp.rs` to verify its behavior when encountering a `ConnectionReset` error reading an incoming stream. The test utilizes `libc::setsockopt` with `SO_LINGER` to reliably simulate a stream dropping with a TCP RST on both Unix and Windows via FFI. Added `libc` as a `dev-dependency` to support this logic. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Adds a test to `handle_connection` in `crates/poke-around/src/mcp.rs` to verify its behavior when encountering a `ConnectionReset` error reading an incoming stream. The test utilizes the `rustix` crate (with `set_socket_linger`) to reliably simulate a stream dropping with a TCP RST on both Unix and Windows via safe standard methods. Added `rustix` as a `dev-dependency` to support this logic. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Added missing connection read error test as requested.
The rationale stated: "It requires setting up a mock stream that errors on read, but this is a standard test for connection handlers."
Because
handle_connectionexpects a concreteTcpStreamrather than a genericReadtrait, we couldn't just pass a custom mocked struct. Instead, the test relies on binding an ephemeral test server, connecting a real client stream, settingSO_LINGERto a 0 timeout using FFI from thelibccrate, and dropping the client. This reliably triggers a nativeConnectionResetOS error when the server attempts to read from it.libcto[dev-dependencies]for testing support.test_handle_connection_read_errortocrates/poke-around/src/mcp.rswhich verifies the error logic.PR created automatically by Jules for task 14837838571348509312 started by @undivisible