🧹 Code Health: Extract HTTP routing in MCP server#26
Conversation
…on`. Extracted the deeply nested `if/else` block inside `handle_connection` in `crates/poke-around/src/mcp.rs` into a new `route_http_request` function. This reduces cognitive complexity, unifies the error logging path, and improves testability. Added `HttpResponse::not_found()` to standardise handling of 404 responses. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Extracted the nested HTTP routing logic from
handle_connectioninto a separateroute_http_requestfunction incrates/poke-around/src/mcp.rs. Added anot_found()helper method toHttpResponse.💡 Why: Reduces cognitive complexity inside the
handle_connectionfunction. The fallback 404 behavior is now standardized within the returnedHttpResponse, unifying the final output and verbose logging paths.✅ Verification: Ran
cargo checkandcargo testto ensure all functionality is preserved. Validated the changes with a code review.✨ Result: Improved readability and maintainability of the HTTP connection handling logic.
PR created automatically by Jules for task 9013493340335507373 started by @undivisible