🧹 Refactor run_bridge to improve code health#25
Conversation
Extracted the tunnel starting logic into `start_tunnel_runner` and the tunnel monitoring loop into `monitor_tunnel`. This reduces the deep nesting in the `run_bridge` loop, making it much easier to read and maintain. Also introduced `StartTunnelResult` and `MonitorTunnelResult` enums to clearly represent the possible outcomes from each phase. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The code health issue addressed is the deep nesting and high cognitive complexity within the
run_bridgefunction incrates/poke-around/src/bridge.rs.💡 Why:
run_bridgecontained two complex nested event loops within an overarching while loop. This made the logic difficult to follow, hard to test, and prone to error if modifications were needed. Extracting the start logic and monitoring logic into dedicated functions with explicit return types (StartTunnelResultandMonitorTunnelResult) drastically improves maintainability.✅ Verification: I ran
cargo check,cargo clippy, andcargo testin thecrates/poke-arounddirectory, confirming that no tests are broken and the refactoring maintains existing functionality. Also requested code review and applied feedback to ensure proper error propagation formake_poke.✨ Result: The
run_bridgefunction is now much cleaner, the flow is straightforward, and the code overall is much healthier.PR created automatically by Jules for task 4031754406396657584 started by @undivisible