🧪 [testing] Add daemon tests to test daemon graceful shutdown#22
Conversation
Adds `daemon_tests.rs` to spawn the `poke-around` executable and ensure that the daemon starts successfully and stops gracefully when encountering a `SIGINT`. Also updates `Cargo.toml` to include `libc` as a dev dependency. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Adds `daemon_tests.rs` to spawn the `poke-around` executable and ensure that the daemon starts successfully and stops gracefully when encountering a `SIGINT`. Also updates `Cargo.toml` to include `libc` as a dev dependency. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Adds `daemon_tests.rs` to spawn the `poke-around` executable and ensure that the daemon starts successfully and stops gracefully when encountering a `SIGINT`. Also updates `Cargo.toml` to include `libc` as a dev dependency. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
🎯 What: The testing gap addressed
The daemon process starts multiple tasks and binds to TCP sockets and blocks to keep the system running. Testing the binary directly was not implemented previously, creating a gap for integration testing on the lifecycle of the daemon process.
📊 Coverage: What scenarios are now tested
This commit adds an integration test (
daemon_tests.rs) that starts the daemon subprocess via Cargo, verifies it printslistening onto stderr, and validates that it stops gracefully when sent aSIGINT.✨ Result: The improvement in test coverage
We now have automated integration test coverage ensuring that the daemon lifecycle handles interrupts gracefully across the system.
PR created automatically by Jules for task 17628443897640947090 started by @undivisible