Skip to content

🧪 Add test coverage for ensure_auth error paths#14

Merged
undivisible merged 2 commits into
mainfrom
add-ensure-auth-test-10564882143634054329
Jun 10, 2026
Merged

🧪 Add test coverage for ensure_auth error paths#14
undivisible merged 2 commits into
mainfrom
add-ensure-auth-test-10564882143634054329

Conversation

@undivisible

Copy link
Copy Markdown
Owner

🎯 What: The testing gap in ensure_auth regarding error handling has been addressed.
📊 Coverage: The scenario where the rs_poke::get_token network request/credentials store yields an error (simulated via invalid JSON credentials) is now tested.
Result: Increased test coverage and robustness of the ensure_auth function. Tests run safely via serial_test.


PR created automatically by Jules for task 10564882143634054329 started by @undivisible

This adds a test verifying that `ensure_auth` correctly returns an error when reading an invalid credentials file.

- Uses `serial_test` crate to avoid data races during `std::env::set_var`.
- Modifies `XDG_CONFIG_HOME` safely inside an `unsafe` block for Rust 1.80+ compatibility.
- Ensure the original environment variable is restored even if the assertion passes or fails.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@undivisible undivisible merged commit b873b25 into main Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant