Skip to content

🧪 [testing improvement] Add tests for agents.rs#13

Merged
undivisible merged 1 commit into
mainfrom
add-agents-tests-7305970587691934885
Jun 10, 2026
Merged

🧪 [testing improvement] Add tests for agents.rs#13
undivisible merged 1 commit into
mainfrom
add-agents-tests-7305970587691934885

Conversation

@undivisible

Copy link
Copy Markdown
Owner

🎯 What: The agents.rs file was lacking tests, leaving the path resolution and agent creation logic untested.
📊 Coverage: Added test coverage for find_agent, create_agent, and find_js_runtime.
Result: Increased test coverage for the agents module and introduced a safe environment variable mocking utility (EnvGuard) to prevent cross-test pollution.


PR created automatically by Jules for task 7305970587691934885 started by @undivisible

This commit introduces comprehensive unit tests for `crates/poke-around/src/agents.rs`. The tests verify the correct behavior of the agent lookup and resolution mechanisms:
- `test_find_agent_exact_match`
- `test_find_agent_js_extension`
- `test_find_agent_not_found`
- `test_create_agent`
- `test_find_js_runtime`

A test environment guard was implemented to safely mock the `XDG_CONFIG_HOME` environment variable across threads without mutating the global state of the entire test runner.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@undivisible undivisible merged commit fdb417e into main Jun 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant