[UNDERTOW-2116] ServletOutputStreamImpl incorrectly sets Content-Length to 0#1345
Merged
Merged
Conversation
Contributor
Author
f025cf8 to
84a3a9e
Compare
Contributor
Author
|
There was a little mistake. Adding more tests to cover that too. |
fl4via
approved these changes
Jul 13, 2022
Member
|
since this was the first PR for this Jira, I'm merging it, even though contributors can keep in mind that now fixes are backported to 2.2.x often and there is no need for PRs for 2.2.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2116
Main modifications:
ServletOutputStreamImplonly resets to 0 if it's not a HEAD method.closeandcloseAsync).sendErrorandsendRedirectinHttpServletResponseImplclean any possibleContent-Lengthheader added before by the app.This PR is for the maintenance branch 2.2.x.
PR for master: #1346
@fl4via Please review this in order to fix JBEAP-23796 (blocker now) when you have time.