Ordering of property declaration attributes (ObjC)#765
Ordering of property declaration attributes (ObjC)#765gmaurel merged 6 commits intouncrustify:masterfrom
Conversation
|
Nicely done! Still, in order to prove your changes are working the way you want they have to be covered by tests. Can you add some ? |
|
We really need somebody who handled the very numerous issues with ObjC. |
|
A few fixes + test added |
|
As for the issues - I don't promise anything, but will try to check. |
|
Is it possible to merge this or do you want any more changes ? |
| std::vector<ChunkGroup> ref_chunks; // retain, copy, assign, weak, strong, unsafe_unretained | ||
| std::vector<ChunkGroup> getter_chunks; // getter | ||
| std::vector<ChunkGroup> setter_chunks; // setter | ||
| std::vector<ChunkGroup> nullability_chunks; // nonnull/nullable |
There was a problem hiding this comment.
Missing null_resettable
| chunk_t *open_paren = NULL; | ||
| chunk_t *close_paren = NULL; | ||
|
|
||
| std::vector<ChunkGroup> thread_chunks; // atomic/nonatomic |
There was a problem hiding this comment.
This group is also missing class property support
|
@daniel-beard Thank you! Will add. |
|
When used together with @property (nonatomic, strong, readonly) NSString * currentString;
@property (nonatomic, assign) BOOL shouldNotifyDelegateOfHeightUpdate; |
|
@Krizai |
|
@daniel-beard @cheeseonhead Please check the update |
Based on existing pull request ( #217 )
I've extracted the topic related stuff from it and added support for a few new attributes.